Skip to content

Temporarily disable test case for query-param matching until #1993 gets resolved #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Temporarily disable test case for query-param matching until #1993 gets resolved #2052

wants to merge 1 commit into from

Conversation

@gauravkghildiyal
Copy link
Member

@gauravkghildiyal gauravkghildiyal commented May 22, 2023

What type of PR is this?
/kind test
/kind failing-test

What this PR does / why we need it:
Disable test until we have clarified #1993

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 22, 2023

Hi @gauravkghildiyal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gauravkghildiyal gauravkghildiyal force-pushed the httproute-matching-priority-temp-disable branch from ff0450f to d9b564d Compare May 22, 2023 19:02
@gauravkghildiyal gauravkghildiyal mentioned this pull request May 22, 2023
Merged
@gauravkghildiyal
Copy link
Member Author

gauravkghildiyal commented May 22, 2023

/cc @sunjayBhatia

@k8s-ci-robot k8s-ci-robot requested a review from sunjayBhatia May 22, 2023 19:06
sunjayBhatia
sunjayBhatia approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Might need a maintainer to also add the cherry-pick labels/comments if this is approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
shaneutt
shaneutt approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/cc @robscott @youngnick

@robscott
Copy link
Member

robscott commented May 22, 2023

Thanks @gauravkghildiyal! Note that if this merges we'll need to undo this when #1993 is resolved. Adding a hold because it seems like we may be able to resolve that fairly quickly and then not need this change.

/approve
/hold
/cherry-pick release-0.7

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented May 22, 2023

@robscott: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

In response to this:

Thanks @gauravkghildiyal! Note that if this merges we'll need to undo this when #1993 is resolved. Adding a hold because it seems like we may be able to resolve that fairly quickly and then not need this change.

/approve
/hold
/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, robscott, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, robscott, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@robscott robscott added this to the v0.7.1 milestone May 22, 2023
@robscott robscott added the release-blocker MUST be completed to complete the milestone label May 22, 2023
@robscott
Copy link
Member

robscott commented May 22, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 22, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 22, 2023
@gauravkghildiyal
Copy link
Member Author

gauravkghildiyal commented May 22, 2023

@robscott

Adding a hold because it seems like we may be able to resolve that fairly quickly and then not need this change.

That sounds completely fine.

I've sent out #2054 (assuming if the solution is straightforward)

@gauravkghildiyal
Copy link
Member Author

gauravkghildiyal commented May 23, 2023

/close in favour of #2054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaneutt shaneutt shaneutt approved these changes

@keithmattix keithmattix Awaiting requested review from keithmattix

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

+1 more reviewer

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sunjayBhatia sunjayBhatia

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-blocker MUST be completed to complete the milestone release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v0.7.1

Development

Successfully merging this pull request may close these issues.

6 participants

@gauravkghildiyal @k8s-ci-robot @robscott @k8s-infra-cherrypick-robot @shaneutt @sunjayBhatia